Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDAPI-113] [C++][Tools] Tools should report invalid event type #53

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

ttldtor
Copy link
Collaborator

@ttldtor ttldtor commented Jul 24, 2024

Tools should report invalid event type.

For example, if the user specified an invalid type 11111, then Tools should return the message:

"There are unknown event types: 11111! List of available event types:
<List of available event types>"

If for some reason the resulting list of types is empty, the following message should appear:
"The resulting list of types is empty!"

@ttldtor
Copy link
Collaborator Author

ttldtor commented Jul 24, 2024

  • Added classes: RuntimeException, InvalidArgumentException
  • InvalidArgumentException, GraalException, JavaException are now descendants of the RuntimeException class, which can collect stacktrace.
  • Now an InvalidArgumentException exception is thrown instead of the std::invalid_argument exception.
  • Tools now reports incorrect event types specified by the user.

@ttldtor ttldtor marked this pull request as ready for review July 24, 2024 15:48
@ttldtor ttldtor merged commit 2c647fd into main Jul 24, 2024
21 checks passed
@ttldtor ttldtor deleted the feature/MDAPI-113 branch July 24, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants